Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifies naming for isArray in Schema class properties #7691

Conversation

spacether
Copy link
Contributor

We are using multiple properties that mean this schema is type array. The properties are:

  • isListContainer
  • isArrayModel

This PR updates our java classes that implement Schema to be consistent in out naming and getters and setters for this property. These classes have been updated:

  • CodegenProperty
  • CodegenModel
  • CodegenParameter
  • CodegenResponse

This PR:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team Members
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)

@spacether spacether added this to the 5.0.0 milestone Oct 13, 2020
@spacether spacether force-pushed the fix/updates_array_propeties_for_consistency branch from 4ed8ce7 to 941d9e9 Compare October 18, 2020 23:51
@spacether spacether force-pushed the fix/updates_array_propeties_for_consistency branch from 1b18353 to 5e5516b Compare October 19, 2020 03:10
@spacether spacether merged commit 3d337db into OpenAPITools:master Oct 19, 2020
@spacether spacether deleted the fix/updates_array_propeties_for_consistency branch October 19, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant