Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-restbed-server] make the restbed SERVER generator more extensible #7679

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

f18m
Copy link
Contributor

@f18m f18m commented Oct 12, 2020

RestBed server code is currently unusable. This MR makes it more extensible by giving the users a chance to setup shared pointers to the restbed::Resource and customize them before they get published into RestBed.

@wing328
Copy link
Member

wing328 commented Oct 14, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@f18m
Copy link
Contributor Author

f18m commented Oct 14, 2020

Hi @wing328 ,
that's not a problem for me (the fact the commits are not linked to my github account I mean).. is fixing this aspect something required to have the PR accepted ? :)

@f18m
Copy link
Contributor Author

f18m commented Oct 17, 2020

Hi @wing328 ,
I have fixed the problem by validating the email address used in the commits I did originally... now github recognizes them as belonging to my account!

@f18m f18m changed the title Make the restbed SERVER generator more extensible [cpp-restbed-server] make the restbed SERVER generator more extensible Oct 17, 2020
@wing328
Copy link
Member

wing328 commented Oct 22, 2020

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

cc @stkrwork as well (the author of the c++ restbed generator)

@f18m
Copy link
Contributor Author

f18m commented Oct 27, 2020

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

cc @stkrwork as well (the author of the c++ restbed generator)

ping :)

I would like to develop other patches for this c++ restbed generator as I started using it in a few of my projects but I'd really like to understand first if there is interest in these patches or not :)

@wing328
Copy link
Member

wing328 commented Oct 27, 2020

If no more feedback on this PR, I'll merge it on coming Wed.

@muttleyxd
Copy link
Contributor

Sorry for late review, but I've been a bit busy recently. Changes look fine for me, definitely a big improvement 👍

@wing328
Copy link
Member

wing328 commented Oct 27, 2020

@muttleyxd no need to apologize. We're all busy :) . Appreciate your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants