Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds isDate to CodegenModel #7652

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 11, 2020

This PR:

Note: this is potentially a breaking change because if one is generating a model for a date schema, the current master branch sets isString in that CodegenModel to true. After this PR, isString will be False and isDate will be true, which is consistent with how date schemas are handled in these classes:

  • CodegenProperty
  • CodegenParameter
  • CodegenResponse

Setting isString and isDate for date schemas should be consistent in these 4 classes.

Checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team Members
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)

@spacether spacether changed the title Adds isDate to CodegenModel, adds test, adds isDate getter and setter… Adds isDate to CodegenModel Oct 11, 2020
@spacether spacether added this to the 5.0.0 milestone Oct 11, 2020
@spacether spacether merged commit ee2a735 into OpenAPITools:master Oct 11, 2020
@spacether spacether deleted the adds_isDate_property branch October 11, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Implement needed common isX properties in java Schema classes in openapi core
1 participant