Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifies naming for isMap in Schema class properties #7640

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 9, 2020

We are using multiple properties that mean this schema is type object. The properties are:

  • isMapContainer
  • isMapModel

This PR updates our java classes that implement Schema to be consistent in out naming and getters and setters for this property. These classes have been updated:

  • CodegenProperty
  • CodegenModel
  • CodegenParameter
  • CodegenResponse

Note: this is a map version of this array PR
This PR

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team Members
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good but I didn't check every single files.

There's only 1 file change in the sample and that change looks good to me.

@spacether spacether force-pushed the fix/updates_map_propeties_for_consistency branch from b57405b to 7cd1554 Compare October 12, 2020 14:59
@spacether spacether merged commit 0cfe023 into OpenAPITools:master Oct 12, 2020
@spacether spacether deleted the fix/updates_map_propeties_for_consistency branch October 12, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants