Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose batch subcommand #7608

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

gillg
Copy link
Contributor

@gillg gillg commented Oct 5, 2020

When you use the very usefull batch subcommand you can't use docker on npm wrapper.
https://openapi-generator.tech/docs/usage/#batch

NPM CLI Wrapper use help subcommand to validate possibles arguments https://github.com/OpenAPITools/openapi-generator-cli/blob/master/apps/generator-cli/src/app/services/pass-trough.service.ts#L21 so you get an error error: unknown command 'batch' when you use it.

In some cases, Docker image also could forbid usage of batch.

I will open a PR in https://github.com/OpenAPITools/openapi-generator-cli to propose usage of completion in place of help to check possible commands, but I think batch should no be hidden in help.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@gillg
Copy link
Contributor Author

gillg commented Oct 5, 2020

Fixed in NPM Wrapper by @kay-schecker in OpenAPITools/openapi-generator-cli#44

Let see if we expose it in help or not...

@jimschubert jimschubert added this to the 5.0.0 milestone Oct 6, 2020
@jimschubert
Copy link
Member

Awesome. Thanks for hooking this up.

I think it makes a lot of sense. I'd written the batch command really only to speed up this project's builds, and was going to unhide if people showed interest. There's been a ton of interest and use of the command, so I think it should be officially exposed.

@jimschubert jimschubert merged commit 9236d56 into OpenAPITools:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants