Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elixir] Fixes optional body mapping #7606

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

mrmstn
Copy link
Contributor

@mrmstn mrmstn commented Oct 5, 2020

Closes #5234

This PR will map an optional body param, given by the static key body to the request body. This makes it relatively transparent to read what actually happens, instead of "mapping the title" in the optional param. This is also the default behavior for primitiv types.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
    cc: @wing328 I'm sorry it's you again 🙈

@mrmstn
Copy link
Contributor Author

mrmstn commented Oct 5, 2020

Hmm... I've no idea why the pipeline failed, could someone trigger the Shippable Action again?

@wing328
Copy link
Member

wing328 commented Oct 9, 2020

@mrmstn restarted and all tests passed 👍

cc: @wing328 I'm sorry it's you again 🙈

No problem. Thanks again for the PR. Have a nice weekend.

@wing328 wing328 merged commit 690be29 into OpenAPITools:master Oct 9, 2020
@mrmstn mrmstn deleted the 5234-optional-request-body branch October 9, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Elixir generated client does not work with optional request body
2 participants