Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elixir] Fixes Typespec for multiple return definitions #7604

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

mrmstn
Copy link
Contributor

@mrmstn mrmstn commented Oct 5, 2020

This PR fixes the wrong typespec for mutiple return types. (Closes #3958)

It does first building and generating a list for every return type defined. Those are saved in a HashList to ensures that every defintion will only be present once.
After that, the list will be added to the existing StringBuffer and adding the {:error, Tesla.Env.t} at the end of the typespec.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
    @wing328 Since you're the only one I know here, could you do me the favor and review my changes :)?

@wing328 wing328 added this to the 5.0.0 milestone Oct 10, 2020
@wing328 wing328 merged commit 242f648 into OpenAPITools:master Oct 10, 2020
@mrmstn mrmstn deleted the 3958-Wrong-exdoc-spec branch October 10, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Elixir] Wrong api client spec on multiple result types
2 participants