Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE]: replace deprecated methods #7600

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

codymikol
Copy link
Contributor

replace setConfig and setOpenApi with the
non-deprecated config / openAPI methods

Fixes N/A

Replace usages of setOpenAPI and setConfig with non-deprecated usages config / openAPI.

There also seem to be a bunch of unused deprecated methods in this package. Are these used by some third party or can these be pruned if unused?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

replace setConfig and setOpenApi with the
non-deprecated config / openAPI methods

Fixes N/A
@wing328
Copy link
Member

wing328 commented Oct 5, 2020

cc @OpenAPITools/generator-core-team

@jimschubert
Copy link
Member

I think now is the time to make the change for these methods. We were stuck with them before 5.0 due to our rule about breaking changes.

Regarding unused methods, are you seeing methods in static analysis which are unused? If so, can you provide more details? We have a lot of SuppressWarnings with unused, but for the most part those are for tests, CLI options, and any place where reflection might be used in a way that IDEs don't know things are used when they are.

@jimschubert jimschubert added Breaking change (with fallback) Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 17, 2020
@jimschubert jimschubert added this to the 5.0.0 milestone Oct 17, 2020
@jimschubert jimschubert merged commit fed9d06 into OpenAPITools:master Oct 19, 2020
@wing328 wing328 changed the title CHORE[CORE]: replace deprecated methods [CORE]: replace deprecated methods Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change (with fallback) Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants