Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][JVM] Move java specific import mappers to JVM specific code gen #7569

Merged

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 1, 2020

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@agilob agilob changed the title Move java specific import mappers to java specific code gen Move java specific import mappers to JVM specific code gen Oct 2, 2020
@agilob agilob changed the title Move java specific import mappers to JVM specific code gen [Java][JVM] Move java specific import mappers to JVM specific code gen Oct 3, 2020
@agilob
Copy link
Contributor Author

agilob commented Oct 4, 2020

CircleCi fails with "new" files:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   samples/client/petstore/elixir/.openapi-generator/FILES
	modified:   samples/server/petstore/php-laravel/.openapi-generator/FILES

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	samples/client/petstore/elixir/lib/openapi_petstore/model/file.ex
	samples/client/petstore/elixir/lib/openapi_petstore/model/list.ex
	samples/server/petstore/php-laravel/lib/app/Models/File.php
	samples/server/petstore/php-laravel/lib/app/Models/ModelList.php

no changes added to commit (use "git add" and/or "git commit -a")

These arent my changes

@agilob
Copy link
Contributor Author

agilob commented Oct 13, 2020

bump @jimschubert @wing328

@jimschubert jimschubert added this to the 5.0.0 milestone Oct 20, 2020
@jimschubert
Copy link
Member

Looks good, thanks!

@jimschubert jimschubert merged commit 7318ff7 into OpenAPITools:master Oct 20, 2020
@wing328
Copy link
Member

wing328 commented Oct 20, 2020

	samples/client/petstore/elixir/lib/openapi_petstore/model/file.ex
	samples/client/petstore/elixir/lib/openapi_petstore/model/list.ex
	samples/server/petstore/php-laravel/lib/app/Models/File.php
	samples/server/petstore/php-laravel/lib/app/Models/ModelList.php

I wonder if these files should be created as a result of this PR.

@wing328
Copy link
Member

wing328 commented Oct 22, 2020

Just did another review and confirmed these are correct output.

Thanks @agilob again for the bug fixes.

@agilob agilob deleted the move-java-specific-import-mappings branch September 25, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants