Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Removal of deprecated Dart generators and generated code #7568

Merged
merged 6 commits into from
Oct 4, 2020

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 1, 2020

Closes #7561

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert
Copy link
Member

I'm all for this as it's not really a blocker (people who want to use deprecated generators can use up to 5.0.0-beta2).

cc @OpenAPITools/generator-core-team do you agree?

@agilob agilob marked this pull request as ready for review October 2, 2020 06:39
@agilob
Copy link
Contributor Author

agilob commented Oct 2, 2020

Ok then, calling maintainers
@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12) @noordawod @sbu-WBT @josh-burton @syky27

README.md Outdated Show resolved Hide resolved
@wing328
Copy link
Member

wing328 commented Oct 3, 2020

About Dart (1.x) petstore tests (deleted as part of this PR, which is fine), can we reuse/copy/plot the following to Dart2 petstore tests?

  • samples/client/petstore/dart/petstore/test/tests.dart
  • samples/client/petstore/dart/petstore/test/tests.html

(we can do it later with a separate PR)

@agilob
Copy link
Contributor Author

agilob commented Oct 3, 2020

I've checked the other tests and looks like most of it is already covered in the new (dart2) test scenarios. I can add some tests after #7585 gets int

@agilob
Copy link
Contributor Author

agilob commented Oct 3, 2020

The next step will be migration of dart openapi schema from 2_0 to 3_0. Just checked it, it will change a lot

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 61b543f into OpenAPITools:master Oct 4, 2020
@wing328 wing328 added this to the 5.0.0 milestone Oct 26, 2020
@agilob agilob deleted the removal-of-old-dart branch September 25, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Remove Dart (1)
3 participants