-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart] Removal of deprecated Dart generators and generated code #7568
Conversation
I'm all for this as it's not really a blocker (people who want to use deprecated generators can use up to 5.0.0-beta2). cc @OpenAPITools/generator-core-team do you agree? |
Ok then, calling maintainers |
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartClientCodegen.java
Outdated
Show resolved
Hide resolved
About Dart (1.x) petstore tests (deleted as part of this PR, which is fine), can we reuse/copy/plot the following to Dart2 petstore tests?
(we can do it later with a separate PR) |
I've checked the other tests and looks like most of it is already covered in the new (dart2) test scenarios. I can add some tests after #7585 gets int |
The next step will be migration of dart openapi schema from 2_0 to 3_0. Just checked it, it will change a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7561
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master