Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] Fix server example on non-Linux #7399

Merged
merged 4 commits into from
Oct 5, 2020
Merged

[rust-server] Fix server example on non-Linux #7399

merged 4 commits into from
Oct 5, 2020

Conversation

mattdowdell
Copy link
Contributor

@mattdowdell mattdowdell commented Sep 11, 2020

The server example is broken because it tries to import use openssl::ssl::SslAcceptorBuilder; unconditionally when it won't be present on MacOS, Windows or iOS and then conditionally provides create causing compile errors on the aforementioned platforms which try to unconditionally import said function in main.rs.

To fix, we simply move the condition from the function to the import and all is happy again :)

To verify, generate the code from any spec, then attempt to use the server example on one of the problem platforms.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @frol @farcaller @richardwhiuk @paladinzh for review.

The server example is broken because it tries to import `use openssl::ssl::SslAcceptorBuilder;` unconditionally when it won't be present on MacOS, Windows or iOS and then conditionally provides `create` causing compile errors on the aforementioned platforms.

To fix, we simply move the condition from the function to the import and all is happy again :)
@mattdowdell
Copy link
Contributor Author

mattdowdell commented Sep 13, 2020

@wing328
Copy link
Member

wing328 commented Sep 26, 2020

Thanks for the PR. I've merged the latest master into this branch. Let's see if that fixes the CI failures.

Copy link
Contributor

@richardwhiuk richardwhiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

Thanks!

@richardwhiuk richardwhiuk merged commit 8c11c8f into OpenAPITools:master Oct 5, 2020
@mattdowdell mattdowdell deleted the patch-1 branch October 5, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants