Update Vert.x Web template to Vert.x 4 #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <[email protected]>
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01) and @wing328 |
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
wing328
reviewed
Sep 16, 2020
modules/openapi-generator/src/main/resources/JavaVertXWebServer/supportFiles/pom.mustache
Outdated
Show resolved
Hide resolved
wing328
reviewed
Sep 16, 2020
| public void postProcessParameter(CodegenParameter parameter) { | ||
| super.postProcessParameter(parameter); | ||
| if (parameter.isUuid || parameter.isDate || parameter.isDateTime) { | ||
| parameter.dataType = "String"; |
There was a problem hiding this comment.
@slinkydeveloper what about updating typeMapping instead to map these types (e.g. UUID) with "String"?
There was a problem hiding this comment.
WDYM? Vert.x doesn't have any "strong" mapping for uuid/date/datetime
There was a problem hiding this comment.
I'll submit a separate PR to show you how I would have done it.
There was a problem hiding this comment.
I've filed #7457. Please take a look when you've time.
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7352
Changes to the codegen/template:
Signed-off-by: Francesco Guardiani [email protected]
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterAdditional context
So the generator works perfectly, generates compiling code and runs it. But, if you run the generated sample, the application crash because of a bug i've found while developing this generator 😄 I fixed it and, with the new version bump, it should work fine vert-x3/vertx-web#1696