Fix multi-part binary form parameters for jaxrs-jersey templates

[itaru2622]

Multi-part binary array form as outlined in #7330 resulted in a single of InputStream and a single of FormDataContentDisposition rather than List of them. This PR attempts to resolv above by adjusting the templates for jaxrs-jersey. Changes to these templates include:

• use FormDataBodyPart rather than {InputStream and FormDataContentDisposition } and wrap it in List where appropriate, as described in issue [BUG] [jaxrs-jersey] [java] [jersey] Generated API interface treats multipart arrays as a single file #7330 'choice C'
• test have been added

Fix #7330

technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[itaru2622]

CI all tests passed.

@wing328 Could you review this PR, please.

[itaru2622]

PR branch is rebased on latest master as of 'Sep 23 02:45:29 2020', and resolved confliction in
modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jaxrs/JavaJerseyServerCodegenTest.java

[itaru2622]

PR branch is rebased on latest master as of 'Oct 14 10:13:17 2020 +0800'.

To technical committee and maintainers:

Please let me know your estimation when this PR is reviewed and merged into master?
It is hard to keep rebasing my branch for following master changes...

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda @wing328 @jimschubert and all

[wing328]

@itaru2622 thanks for the PR, which has been merged into master but it's causing build failures.

I've commented out the test via 07c23f4. I wonder if you can pull the latest master to take a look when you've time. Thanks.

[itaru2622]

@wing328 first, Thank you for merging.

• latest master has no 'List' in the above test case at this moment, so you needed 07c23f4 to build successfully .

• my PR branch can build successfully without 07c23f4, and it has 'List' in case of "multipartArray" at test/resources/3_0/form-multipart-binary-array.yaml.

hmm... I will check some-how with latest master.

[itaru2622]

@wing328 I found the reason as bellow, and after little modification including revert 07c23f4, It succeeded building again. ;-)

• latest master uses 'isArray' instead of 'isListContainer' in mustache, but my PR branch was using 'isListContainer'.
• I guessed, mustache rule was changed from 'isListContainer' to 'isArray' recently ...

my little modification is:

• I changed all 'isListContainer' into 'isArray' in below three files to follow above rule, by sed 's/isListContainer/isArray/g'
  • modules/openapi-generator/src/main/resources/JavaJaxRS/formParams.mustache
  • modules/openapi-generator/src/main/resources/JavaJaxRS/libraries/jersey1/formParams.mustache
  • modules/openapi-generator/src/main/resources/JavaJaxRS/serviceFormParams.mustache
  • these three files were needed to be changed for fixing [BUG] [jaxrs-jersey] [java] [jersey] Generated API interface treats multipart arrays as a single file #7330
• don't forget reverting 07c23f4

Let me know what should I do next.

The above description is enough for you? or ...
Is it better to push my change into my PR branch with or without reverting 07c23f4 ?
Do I need to run ./bin/generate-samples.sh before push?

I'm looking forward hearing from you... ;-)

[wing328]

@itaru2622 ah right. Forgot about the isArray change (I thought the PR hasn't merged yet).

I've filed #7806 to fix the issue. CI tests look good so far.

[itaru2622]

@wing328 Thank you for #7806.

I confirmed it passed all CI test. please merge #7806 to master... or Is there any task remained yet?