Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp pistache] use model namespace only on Model import #733

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • When no models are being imported, avoid using the namespace to prevent compilation failure.
  • No impact to current petstore

Fixes #637

@stkrwork @MartinDelille @ravinikam @fvarose

@etherealjoy
Copy link
Contributor Author

@CyrilleBenard
This will solve your issue #637

@etherealjoy etherealjoy changed the title [cpp pistache] use namespace only on Model import [cpp pistache] use model namespace only on Model import Aug 3, 2018
@etherealjoy
Copy link
Contributor Author

#637 confirmed solved by @CyrilleBenard

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples were regenerated?

looks good

@etherealjoy
Copy link
Contributor Author

I generated samples, no changes for PetStore because models are always used.

@etherealjoy etherealjoy added this to the 3.2.1 milestone Aug 7, 2018
@etherealjoy etherealjoy merged commit baf16cf into OpenAPITools:master Aug 7, 2018
@etherealjoy etherealjoy deleted the cpp_pistache_use_namespace_on_import branch August 7, 2018 15:59
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants