-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpprestsdk] Add localVar prefix to parameterized functions variables #731
[cpprestsdk] Add localVar prefix to parameterized functions variables #731
Conversation
…k in order to make name clashing less probable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stkrwork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me but i've not tested it locally
why the localVar word? why not something like __ instead? |
|
@Jauler thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832 |
…k in order to make name clashing less probable. (OpenAPITools#731)
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,4.0.x
. Default:master
.Description of the PR
Proposed solution for #660 rename local variables to have prefix localVar in api-source.mustache.
Petstore api source files has hanged so I am adding them into the same commit.
@ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille