Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpprestsdk] Add localVar prefix to parameterized functions variables #731

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

Jauler
Copy link
Contributor

@Jauler Jauler commented Aug 3, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Proposed solution for #660 rename local variables to have prefix localVar in api-source.mustache.
Petstore api source files has hanged so I am adding them into the same commit.

@ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille

…k in order to make name clashing less probable.
Copy link
Contributor

@etherealjoy etherealjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etherealjoy
Copy link
Contributor

@stkrwork
Do you have comments? If not we can go ahead and merge.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but i've not tested it locally

@stkrwork
Copy link
Contributor

why the localVar word? why not something like __ instead?

@wing328
Copy link
Member

wing328 commented Aug 14, 2018

localVar (or local_var_) => it's a prefix we use in other languages as well, e.g. C#, Java, Ruby, Python, etc

@wing328 wing328 merged commit 1c6ab3f into OpenAPITools:master Aug 16, 2018
@wing328 wing328 added this to the 3.2.2 milestone Aug 22, 2018
@wing328 wing328 changed the title [cpprestsdk] Add localVar prefix to parameterized functions variables in cpprestsd… [cpprestsdk] Add localVar prefix to parameterized functions variables Aug 22, 2018
@wing328
Copy link
Member

wing328 commented Aug 22, 2018

@Jauler thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants