-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp pistache] fix leading number in model names and apply modelNamePrefix in all cases #730
[cpp pistache] fix leading number in model names and apply modelNamePrefix in all cases #730
Conversation
@CyrilleBenard class TET5gmmCapability
: public TETModelBase
{
bool _5gItemIsSet() const;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you generate samples? also you might want to adapt the title to also mention that you are adding prefix to everything
@stkrwork |
...api-generator/src/main/java/org/openapitools/codegen/languages/CppPistacheServerCodegen.java
Show resolved
Hide resolved
...s/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCppCodegen.java
Show resolved
Hide resolved
...s/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCppCodegen.java
Show resolved
Hide resolved
Issue not related to PR. |
…refix in all cases (OpenAPITools#730) * Fix numbers in nameInCamelCase. Add possibility to prefix Names to avoid conflicts * Allow unique prefixing for template functions as well
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,4.0.x
. Default:master
.Description of the PR
nameInCamelCase
for variables with a leading number.usage example
With this sample spec
we have something like this
class TET5gmmCapability
--> File namemodel\TET5gmmCapability.h
class TETCheckApiImpl
--> File nameimpl\TETCheckApiImpl.h
class TETCheckApi
--> File nameapi\TETCheckApi.h
class TETModelBase
--> File namemodel\TETModelBase.h
main
--> File nameTETCheckApiMainServer.cpp
Fixes #604
@stkrwork @MartinDelille @fvarose @ravinikam