Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go-server] Modified go-server templates to allow services to receive http request's context. #7214

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

ryutah
Copy link
Contributor

@ryutah ryutah commented Aug 14, 2020

Modifiled go-server templates.

close #6657

Description

  • Added context.Context arguments to below templates
    • api.mustache
    • controller-api.mustache
    • service.mustache
  • Updated go-api-server sample by running ./bin/generate-samples.sh

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ryutah ryutah changed the title Modified go-server templates to allow services to receive http request's context. [go-server] Modified go-server templates to allow services to receive http request's context. Aug 14, 2020
@ryutah
Copy link
Contributor Author

ryutah commented Aug 14, 2020

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)
Please review the pull request!

@kemokemo
Copy link
Contributor

Hi @ryutah !
Thank you for your PR. This looks good to me. 😃

@wing328
Copy link
Member

wing328 commented Aug 14, 2020

@ryutah thanks for the PR, which has been merged into master.

From what I know, this is a breaking change (without fallback) as the method signature has been changed. Please correct me if I'm wrong.

@kemokemo thanks for the prompt review.

@ryutah ryutah deleted the go-server-adds-context-arguments branch August 15, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Go] Pass r.Context into handlers
3 participants