Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for ROR generator #718

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Add Dockerfile for ROR generator #718

merged 1 commit into from
Aug 2, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • add Dockerfile
  • minor fix to mustache templates

Credits go to @ledsun who provides the Dockerfile and docker-entrypoint.sh

To close #713

@wing328
Copy link
Member Author

wing328 commented Aug 2, 2018

Test result looks good locally:

=> Booting Puma
=> Rails 5.0.7 application starting in development on http://0.0.0.0:3000
=> Run `rails server -h` for more startup options
Puma starting in single mode...
* Version 3.12.0 (ruby 2.5.1-p57), codename: Llamas in Pajamas
* Min threads: 5, max threads: 5
* Environment: development
* Listening on tcp://0.0.0.0:3000
Use Ctrl-C to stop
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2018-08-02 11:18:43 +0000 ===
- Goodbye!
Exiting

@wing328
Copy link
Member Author

wing328 commented Aug 2, 2018

cc @cliffano @zlx @ledsun

@wing328 wing328 added this to the 3.2.0 milestone Aug 2, 2018
@wing328 wing328 merged commit f32398a into master Aug 2, 2018
@wing328 wing328 deleted the ror_dockerfile branch August 2, 2018 14:07
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ruby-on-rails] Suggest to generate Dockerfile for Ruby on Rails stub server
1 participant