-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust][reqwest] Fixed parameters of Array type #7049
[Rust][reqwest] Fixed parameters of Array type #7049
Conversation
Not using #isListContainer in parameters
@JRAndreassen thanks for the PR. Please run the following to update the samples so that the CI can verify the result:
(On Windows, please install Git bash to run the above) |
supportAsync set to "false" should be false
Only check for special case... "dataType" case includes Vec
I've fixed the errors I can, and ran the script. There are errors in the build that I'm not sure how to fix...
I tried to run the "ensure-up-to-date", but it fails locally
Thoughts ? JR |
@frol / @farcaller / @richardwhiuk / @paladinzh I have a couple of things I'd like to change / add to the rust/reqwest client...
|
For the errors, I'll take a look in the coming week. For the suggestions, please open an issue to start the discussion and for tracking purpose. |
All CI tests passed. Are the following files added manually?
If yes, what's the purpose of these files? |
Hi... |
@JRAndreassen No need to sorry. Let me investigate. |
Tested manually and no compilation issue found: https://travis-ci.org/github/OpenAPITools/openapi-generator/builds/724698912 |
* master: (1557 commits) [docs] Add notes on Windows classpath modification (OpenAPITools#7404) [C#][netcore] better support for additional properties in the payload (OpenAPITools#7396) Fix the ECDSA signature issue for PowerShellSDK (OpenAPITools#7386) Fix the new package that deal with Configuration (the old one is depecrated) (OpenAPITools#7391) update vonage logo (OpenAPITools#7387) [gradle][plugin] Fix tests (OpenAPITools#7384) [typescript] Fix incorrect enum literal case (OpenAPITools#7378) Rust reqwest/api_mustache Missing api Vec in parameter (OpenAPITools#7049) [kotlin] Fix imports of generated class (OpenAPITools#7314) Properly decode $ref (OpenAPITools#7191) fix typo, update caption feat(r): retry configuration for status codes (OpenAPITools#5925) [json][codegen] Add option: outputFileName (OpenAPITools#7348) RSACng class is not supported on linux replacing it by RSA (OpenAPITools#7349) Adds cookie auth support to ApiKeyAuth in dart2 templates (OpenAPITools#7346) [js][flowtype] Bump lodash from 4.17.15 to 4.17.19 (OpenAPITools#7359) Bugfix swift5 code generation 2966 (OpenAPITools#7301) Syncs validation properties for arraymodels (OpenAPITools#7357) Subclass Python exceptions (OpenAPITools#7321) Adds fix for issue7262 and a test of it (OpenAPITools#7328) ...
@frol / @farcaller / @richardwhiuk / @paladinzh
Fixed parameters of Array type in "rust/reqwest/api.mustache"
the following definition:
Fix for api_mustache ignoring Array's in parameters...
error[E0599]: no method named
join
found for reference&str
in the current scope--> src\apis\product_module_api.rs:110:62
|
110 | form_params.insert("nodeSecretMode", param_value.join(",").to_string());
| ^^^^ method not found in
&str
Not using #isListContainer in parameters
Fixed for both standard and "vendorExtensions.x-group-parameters=true"
and compiles under both