Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Prefix enum number with _ #703

Merged
merged 2 commits into from
Aug 2, 2018
Merged

[Go] Prefix enum number with _ #703

merged 2 commits into from
Aug 2, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #520

The test result looks good:

package openapi
type Bits string

// List of Bits
const (
        _32BIT Bits = "32bit"
        _64BIT Bits = "64bit"
)

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07)

@bvwells
Copy link
Contributor

bvwells commented Aug 1, 2018

Looks good to me!

@wing328
Copy link
Member Author

wing328 commented Aug 1, 2018

@bvwells thanks for the quick review.

(the shippable CI failure has been fixed in the master)

@langston-barrett
Copy link

Might be good to add the test you wrote above to a regression test suite somewhere.

@wing328
Copy link
Member Author

wing328 commented Aug 1, 2018

@siddharthist good idea. May I know if you've time to help contribute a test case for that? We can show you some good starting points.

@langston-barrett
Copy link

@wing328 My project has switched away from using openapi-generator. I appreciate your response to my issues!

@wing328
Copy link
Member Author

wing328 commented Aug 2, 2018

@siddharthist No problem at all 👌 thanks for reporting the issue and reviewing the PR.

We'll add the test later.

@wing328 wing328 merged commit 40024ac into master Aug 2, 2018
@wing328 wing328 deleted the fix_go_enum branch August 2, 2018 02:13
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* prefix enum number with _ in go

* reformat code, use else if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go] Enum: Identifiers cannot begin with numerals
3 participants