Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc string error in Java (rest-assured) client #702

Merged
merged 4 commits into from
Aug 1, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #697 (comment)

@wing328 wing328 added this to the 3.2.0 milestone Aug 1, 2018
@wing328 wing328 changed the title Fix Javado string error in Java (rest-assured) client Fix Javadoc string error in Java (rest-assured) client Aug 1, 2018
@wing328 wing328 merged commit 21141f6 into master Aug 1, 2018
@wing328
Copy link
Member Author

wing328 commented Aug 1, 2018

FYI @viclovsky @jeff9finger

@wing328 wing328 deleted the fix_rest_assured branch August 1, 2018 14:14
@jeff9finger
Copy link
Contributor

👍

1 similar comment
@viclovsky
Copy link
Contributor

👍

@jmini
Copy link
Member

jmini commented Aug 15, 2018

I still have javadoc errors when I run:

mvn verify -f samples/client/petstore/java/rest-assured/

So I think we need one more follow up PR that make the javadoc comment use htmlentities...

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
)

* fix docstring

* trigger build failure

* Revert "trigger build failure"

This reverts commit 12cd26f.

* update java samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants