Skip to content

Conversation

@bit-factor
Copy link
Contributor

@bit-factor bit-factor commented Jul 19, 2020

To fix #6853

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Jul 20, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@bit-factor
Copy link
Contributor Author

Thanks for pointing this out. This was fixed.

@bit-factor
Copy link
Contributor Author

There are a bunch of useless changes after running generate-samples.sh (like from model/./apiResponse.ts to model/apiResponse.ts) which for me kind of make sense to have a simplified path to a resource, but it seems to me like it may be a game of ping-pong with other commits which may revert them back at one moment. Any idea - or quick hint - on how to disable this "simplification" on my side? It should make further commits easier to read (less changes).

@bit-factor
Copy link
Contributor Author

I am a bit confused. The "ci/circleci: build" keep failing. Checking the errors, it seems like I need to run bin/utils/ensure-up-to-date. Fine, I did it, but at the end of the run, there are no files changed on my local machine. Is there anything else I need to run/do to have this PR green? Thanks, I really appreciate any help on this ... I've already lost 2 days trying to fix this.

@bit-factor
Copy link
Contributor Author

@wing328 , any idea/hint on why circleci keeps failing? I ran the scripts locally, all generated files were pushed ... I really don't get it. Thanks!

@bit-factor
Copy link
Contributor Author

WHOA! :) Thanks for the update! Is there anything I can do to avoid this stupid thing in the future? Again, thanks!

@wing328
Copy link
Member

wing328 commented Jul 28, 2020

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328
Copy link
Member

wing328 commented Jul 28, 2020

@bit-factor please run the following to update the Spring samples:

./bin/generate-samples.sh ./bin/configs/spring-*

(on Windows, you will need to install GIT bash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Wrong parameter for multipart-form-data file upload when using java reactive

2 participants