-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Fixed reactor conditions in template #6993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reactor conditions in template #6993
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
…late' of https://github.com/bit-factor/openapi-generator into bugfix/5.0.0-beta/6853-fixed-reactor-conditions-in-template
|
Thanks for pointing this out. This was fixed. |
|
There are a bunch of |
|
I am a bit confused. The "ci/circleci: build" keep failing. Checking the errors, it seems like I need to run |
|
@wing328 , any idea/hint on why circleci keeps failing? I ran the scripts locally, all generated files were pushed ... I really don't get it. Thanks! |
|
WHOA! :) Thanks for the update! Is there anything I can do to avoid this stupid thing in the future? Again, thanks! |
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01) |
|
@bit-factor please run the following to update the Spring samples: (on Windows, you will need to install GIT bash) |
To fix #6853
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master