Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apex] migrating to OpenAPI Generator project #692

Merged
merged 2 commits into from
Jul 31, 2018
Merged

[Apex] migrating to OpenAPI Generator project #692

merged 2 commits into from
Jul 31, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • cherry-pick the commit by @muenzpraeger in Apex #687
  • commented out unused code
  • left comments about revising code
  • Ran ./bin/apex-petstore.sh without issues.

@wing328 wing328 added this to the 3.2.0 milestone Jul 30, 2018
@wing328 wing328 mentioned this pull request Jul 30, 2018
@wing328
Copy link
Member Author

wing328 commented Jul 30, 2018

TODO

@wing328
Copy link
Member Author

wing328 commented Jul 31, 2018

As discussed with @muenzpraeger we'll merge this first and then he will submit PRs to further enhance the Apex client generator

@wing328 wing328 merged commit d8ec6b2 into master Jul 31, 2018
@wing328 wing328 deleted the migrate_apex branch July 31, 2018 08:10
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* [apex] migrating to OpenAPITools

* migrate apex to openapi-generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants