Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cwiki] Path parameter generation fix for split rows #6894

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

Jakesterwars
Copy link
Contributor

Using the cwiki documentation generator will create the path parameters table correctly except for each row after the initial will be spit up. This is due to where the mustache template is placing the header for the path parameters.

Example json spec:
{ "openapi": "3.0.0", "info": { "title": "test", "version": "1.0", "description": "test", "contact": { "name": "asd", "url": "asd", "email": "[email protected]" } }, "servers": [ { "url": "http://localhost:3000" } ], "tags": [ { "name": "test" } ], "paths": { "/test/{id}/{testing}/{pathing}": { "parameters": [ { "schema": { "type": "string" }, "name": "id", "in": "path", "required": true }, { "schema": { "type": "string" }, "name": "testing", "in": "path", "required": true }, { "schema": { "type": "string" }, "name": "pathing", "in": "path", "required": true } ], "get": { "summary": "Your GET endpoint", "tags": [], "responses": { "200": { "description": "OK" } }, "operationId": "testPathing", "description": "asd" } } }, "components": { "schemas": {} } }

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Jakesterwars
Copy link
Contributor Author

I'm getting some cache issues on build preventing me from progressing.

@Jakesterwars
Copy link
Contributor Author

@jhitchcock

@Jakesterwars
Copy link
Contributor Author

@wing328 Sorry for the ping, but this error is happening on not just mine or but other PRs. Do you possible know of a fix or did we by chance mess something up in our clone?

@wing328
Copy link
Member

wing328 commented Sep 16, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added Doc: Cwiki Generation of Cwiki documentation Issue: Bug labels Sep 16, 2020
@Jakesterwars
Copy link
Contributor Author

Thanks for letting me know. I forgot I changed over my account name and such after I did this PR. I'll fix it when I can soon.

@wing328 wing328 merged commit 7e7bfc7 into OpenAPITools:master Oct 22, 2020
@wing328 wing328 added this to the 5.0.0 milestone Oct 22, 2020
@wing328
Copy link
Member

wing328 commented Oct 22, 2020

@Jakesterwars thanks for the PR, which has been merged into master.

@wing328 wing328 modified the milestone: 5.0.0 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc: Cwiki Generation of Cwiki documentation Issue: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants