Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch]: Revert "[typescript-fetch] Support deepObject query params (#6075)" #6860

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

haraldF
Copy link
Contributor

@haraldF haraldF commented Jul 4, 2020

This reverts commit 354f195.

It became superfluous due to some other changes in runtime and changing
of the queryParameters in d9a6f4d

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

…ols#6075)"

This reverts commit 354f195.

It became superfluous due to some other changes in runtime and changing
of the queryParameters in d9a6f4d
@auto-labeler
Copy link

auto-labeler bot commented Jul 4, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@haraldF
Copy link
Contributor Author

haraldF commented Jul 4, 2020

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

review please? You can find the full discussion at #6706

@macjohnny macjohnny added this to the 5.0.0 milestone Jul 7, 2020
@macjohnny macjohnny changed the title Revert "[typescript-fetch] Support deepObject query params (#6075)" [typescript-fetch]: Revert "[typescript-fetch] Support deepObject query params (#6075)" Jul 7, 2020
@macjohnny macjohnny merged commit 566b2b7 into OpenAPITools:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants