Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operationId starting with a number for Python client #682

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 29, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #662

Test result looks good:

[main] WARN  o.o.c.languages.PythonClientCodegen - 123CommonVersion (starting with a number) cannot be used as method name. Renamed to call_123_common_version

@wing328
Copy link
Member Author

wing328 commented Jul 30, 2018

cc technical committee

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11)

@wing328 wing328 merged commit 036fa69 into master Jul 30, 2018
@wing328 wing328 deleted the python-function branch July 30, 2018 07:42
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] Paths starting with numerics
1 participant