Update cpp-tizen class to extend AbstractCppCodegen #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkrwork
requested changes
Jul 28, 2018
| * @return getter name based on naming convention | ||
| */ | ||
| public String toBooleanGetter(String name) { | ||
| return "get" + getterAndSetterCapitalize(name); |
There was a problem hiding this comment.
The doc here says that it generates isActive as an example, but generates getActive. Either adapt the comment or the code
There was a problem hiding this comment.
@stkrwork
I updated javadoc comment to getActive
stkrwork
approved these changes
Jul 28, 2018
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* cpp-tizen extends AbstractCppCodegen * Update javadoc comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.Description of the PR
Fix #674
@stkrwork @wing328 @MartinDelille