Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation error message to show how to disable the validation #653

Merged
merged 4 commits into from
Jul 26, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 26, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • improve validation error message to show how to disable the validation cc @jimschubert
  • improve C++ QT5 generator's description and add Windows batch file cc @etherealjoy
  • fix the invalid spec used by the Swift generator

@wing328 wing328 added this to the 3.2.0 milestone Jul 26, 2018
@etherealjoy
Copy link
Contributor

Ok for the Qt5 server.
I plan more updates to align it with latest C++ changes on master and to rework class name to highlight the framework.

@wing328
Copy link
Member Author

wing328 commented Jul 26, 2018

@etherealjoy 👌 I'll send out a tweet to promote the new server generator after our improvements

@etherealjoy
Copy link
Contributor

@wing328 I created #655 to address @stkrwork concerns and also added the beta tag since it will conflict after merge.

@wing328
Copy link
Member Author

wing328 commented Jul 26, 2018

@etherealjoy 👌 I'll undo the C++ Qt5 server generator-related change in this PR.

@wing328 wing328 merged commit 7e494e5 into master Jul 26, 2018
@wing328 wing328 deleted the various_improvement branch July 26, 2018 17:59
@wing328 wing328 changed the title Various improvements Improve validation error message to show how to disable the validation Aug 6, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* improve validation error message

* minor improvement to qt5 c++ server

* fix invalid spec (causing shippable failure)

* Revert "minor improvement to qt5 c++ server"

This reverts commit 56f356c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants