[JAVA][jaxrs-spec] Added custom methods to add/remove elements from java collections #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wing328 Can you please take a look at this PR. Thanks! |
|
@wing328 gentle remainder. Can we get this in master? |
wing328
reviewed
Mar 27, 2021
| @@ -59,7 +77,25 @@ public ArrayTest arrayArrayOfInteger(List<List<Long>> arrayArrayOfInteger) { | |||
|
|
|||
| public void setArrayArrayOfInteger(List<List<Long>> arrayArrayOfInteger) { | |||
| this.arrayArrayOfInteger = arrayArrayOfInteger; | |||
| }/** | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Minor suggestion: can you please also add proper docstrings for these new methods in another PR?
wing328
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are made to
pojo.mustacheof Jaxrs-spec to generate custom methods to remove or add elements from Java collection such as List, Maps.This resolves issue #6467
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Technical Committee
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)