Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] Avoid HTML escaping of output #645

Merged
merged 1 commit into from
Jul 26, 2018
Merged

[rust-server] Avoid HTML escaping of output #645

merged 1 commit into from
Jul 26, 2018

Conversation

bjgill
Copy link
Contributor

@bjgill bjgill commented Jul 25, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.2.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @frol @farcaller

Description of the PR

We discovered a bug where the mustache templating engine was performing unwanted html escaping. This PR changes all instances of {{foo}} to {{{foo}}}, which disables html escaping. This has no effect on the current sample.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local test result looks good.

@wing328 wing328 merged commit 1d72edd into OpenAPITools:master Jul 26, 2018
@bjgill bjgill deleted the stop-escaping-rust-templates branch July 26, 2018 13:58
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants