[TS][Fetch] Add possibility to pass baseOptions to the API Configuration #642
Conversation
…ll be passed to every fetch call
|
hm the shippable job timed out, do you have any tips / insights on this? |
wing328
changed the title
|
Hi @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny, any question/feedback on this PR? |
| @@ -17,7 +17,7 @@ import * as url from "url"; | |||
| import * as portableFetch from "portable-fetch"; | |||
| import { Configuration } from "./configuration"; | |||
|
|
|||
| const BASE_PATH = "https://petstore.swagger.io *_/ ' \" =end -- \\r\\n \\n \\r/v2 *_/ ' \" =end -- \\r\\n \\n \\r".replace(/\/+$/, ""); | |||
| const BASE_PATH = "http://petstore.swagger.io *_/ ' \" =end -- \\r\\n \\n \\r/v2 *_/ ' \" =end -- \\r\\n \\n \\r".replace(/\/+$/, ""); | |||
There was a problem hiding this comment.
Was this change intentional? It was not changed in this PR. Seems like someone didn't regenerate the samples in another PR?
There was a problem hiding this comment.
yes seems like they were not regenerated before, honestly i don't know much about it, it changed after executing the sample binaries
|
@dsumer thanks for the contribution, which has been merged into master. @macjohnny @TiFu thanks for reviewing the change. |
wing328
changed the title
|
@dsumer thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832 |
…ll be passed to every fetch call (OpenAPITools#642)
…ll be passed to every fetch call
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.2.x,4.0.x. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01)
Description of the PR
add possiblity to pass baseOptions to the API Configuration, which will be passed to every fetch call
useful to pass e.g. { credentials: 'include' } as baseOptions and don't have to pass it to every single API call