[Java] add useNullForUnknownEnumValue option #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed base branch: |
wing328
reviewed
Jul 26, 2018
bin/java-petstore-jersey2.json
Outdated
| "artifactId": "petstore-jersey2" | ||
| "artifactId": "petstore-jersey2", | ||
| "additionalProperties" : { | ||
| "useNullForUnknownEnumValue" : true |
There was a problem hiding this comment.
Minor suggestion: What about using spaces instead of tabs?
There was a problem hiding this comment.
Implemented. Thank you for the review.
wing328
approved these changes
Jul 26, 2018
Spaces instead of tabs
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.2.x,4.0.x. Default:master.cc: @TehBakker, @slarti-b, @wing328, @cbornet
Description of the PR
Fixes #625
This PR introduce a new option
useNullForUnknownEnumValue.falsethe generated code throws an exception when the value is unknown (not present in the enum)true(3.1.xand3.0.xbehavior): unknown values are mapped tonullMigration guide is updated with this PR.
2 Java samples are still using the old behavior:
bin/java-petstore-jersey1.shbin/java-petstore-jersey2.sh