-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Escape media type #615
Conversation
- bin/php-lumen-petstore-server.sh
Technical committee: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko |
@ackintosh Maybe we should also put |
@ackintosh Maybe public String escapeMediaType(String mediaType) {
// "*/*" causes a syntax error
if ("*/*".equals(mediaType)) {
return "*_/_*";
}
return mediaType;
} All other escape functions in |
@ybelenko let's go with this PR to start with. We can always improve the existing code base with another PR. Personally, I'm ok with your approach and @ackintosh 's approach. |
I think doing it once in |
@wing328 hmmm... Weird, I rember that saw merged PR where |
@ybelenko yes, I think eventually we want to just have one postProcess method to work on the operations and We will need a PR to do the cleanup before the major release that removes psotProcessOperations completely. |
* Move escapeMediaType() to AbstractPhpCodegen * Escape media type * Update samples - bin/php-lumen-petstore-server.sh * Refactoring: remove unused 'import'
…-16.x chore(deps): update dependency dotenv to v16
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Description of the PR
In case of using
mediaType
in doc comment,*/*
causes a syntax error.What this PR did: