Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] Implement stack for Context #612

Merged
merged 1 commit into from
Jul 26, 2018
Merged

[rust-server] Implement stack for Context #612

merged 1 commit into from
Jul 26, 2018

Conversation

bjgill
Copy link
Contributor

@bjgill bjgill commented Jul 20, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @frol @farcaller

Description of the PR

This PR adds a SwaggerService trait that makes it much easier to compose multiple middlewares. This single common trait means that middlewares need less boilerplate. This change has been prompted by our experiences with an internal authentication middleware.

This PR also renames auth::Server to context::AddContext, to make the purpose clearer. Given that this is a breaking change (albeit a pretty trivial rename, as the example integration shows), I don't know if I should be filing this against master or 3.2.x...

See Metaswitch/swagger-rs#36 for the associated swagger-rs changes.

Thanks to @jngorman, the original contributor of this commit.

@jmini
Copy link
Member

jmini commented Jul 25, 2018

Changed base branch: 3.2.0-SNAPSHOT is now on master branch

@wing328
Copy link
Member

wing328 commented Jul 26, 2018

@bjgill when you've time, I wonder if you can resolve the merge conflicts and then I'll merge it into master (3.2.0)

@bjgill
Copy link
Contributor Author

bjgill commented Jul 26, 2018

Thanks. Now rebased and awaiting CI.

@bjgill
Copy link
Contributor Author

bjgill commented Jul 26, 2018

CI all passed. Happy to get merged when you're ready.

@wing328 wing328 merged commit b6fc290 into OpenAPITools:master Jul 26, 2018
@bjgill bjgill deleted the swagger-context branch July 27, 2018 00:41
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants