Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When withXml=false we shouldn't add the jaxb imports #6013

Closed
wants to merge 2 commits into from
Closed

When withXml=false we shouldn't add the jaxb imports #6013

wants to merge 2 commits into from

Conversation

Ravisankar-Challa
Copy link
Contributor

When users are just dealing with json and set withXml=false jaxb (Java Api XML binding) imports are not needed.

@Ravisankar-Challa
When withXml=false we shouldn't add the jaxb imports
9065a05 
When users are just dealing with json and set withXml=false jaxb (Java Api XML binding) imports are not needed.
@wing328 wing328 added this to the 4.3.1 milestone Apr 23, 2020
@wing328
Copy link
Member

wing328 commented Apr 23, 2020

@Ravisankar-Challa thanks for the PR. Please run ./bin/java-petstore-microprofile.sh to update the samples to that the CI can verify the result.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328
Copy link
Member

wing328 commented Apr 23, 2020

CircleCI reports the following errors:

[ERROR] COMPILATION ERROR : 
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[44,2] cannot find symbol
 
  symbol:   class XmlType
 
  location: class org.openapitools.client.model.Order
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[45,2] cannot find symbol
 
  symbol:   class XmlEnum
 
  location: class org.openapitools.client.model.Order
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[49,2] cannot find symbol
 
  symbol:   class XmlType
 
  location: class org.openapitools.client.model.Pet
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[50,2] cannot find symbol
 
  symbol:   class XmlEnum
 
  location: class org.openapitools.client.model.Pet
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,2] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,60] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,124] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,2] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,69] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,130] cannot find symbol
 
  symbol:   class XmlEnumValue
 
  location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project microprofile-rest-client: Compilation failure: Compilation failure:
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[44,2] cannot find symbol
 
[ERROR] symbol:   class XmlType
 
[ERROR] location: class org.openapitools.client.model.Order
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[45,2] cannot find symbol
 
[ERROR] symbol:   class XmlEnum
 
[ERROR] location: class org.openapitools.client.model.Order
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[49,2] cannot find symbol
 
[ERROR] symbol:   class XmlType
 
[ERROR] location: class org.openapitools.client.model.Pet
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[50,2] cannot find symbol
 
[ERROR] symbol:   class XmlEnum
 
[ERROR] location: class org.openapitools.client.model.Pet
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,2] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,60] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Order.java:[48,124] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Order.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,2] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,69] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/microprofile-rest-client/src/main/java/org/openapitools/client/model/Pet.java:[53,130] cannot find symbol
 
[ERROR] symbol:   class XmlEnumValue
 
[ERROR] location: class org.openapitools.client.model.Pet.StatusEnum
 
[ERROR] -> [Help 1]
 
[ERROR] 
 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
 
[ERROR] 
 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
 
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
 
[ERROR] 
 
[ERROR] After correcting the problems, you can resume the build with the command
 
[ERROR]   mvn <goals> -rf :microprofile-rest-client
 
2020-04-23 11:45:11.331:INFO::main: Logging initialized @110ms
 
2020-04-23 11:45:11.343:INFO:oejr.Runner:main: Runner
 
2020-04-23 11:45:11.432:INFO:oejs.Server:main: jetty-9.2.9.v20150224

Can you please take a look when you've time?

@Ravisankar-Challa Ravisankar-Challa mentioned this pull request Apr 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Java Enhancement: Compatibility
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Ravisankar-Challa @wing328