Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Fix issue #51, change object mapping from *interface{} to map[st… #60

Merged
merged 2 commits into from Jun 21, 2018
Merged

Conversation

ilk
Copy link
Contributor

@ilk ilk commented May 16, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #51 I propose the following changes:

  1. map swagger object type to map[string]interface{} instead of *interface{}
  2. removing pointer since a map is already a reference type

Technical Commitee

@antihax
@wing328

@wing328
Copy link
Member

wing328 commented May 16, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented May 16, 2018

cc @bvwells as well

@wing328
Copy link
Member

wing328 commented May 18, 2018

@ilk I just noticed that your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented May 18, 2018

@ilk Can you also please run ./bin/go-petstore.sh or .\bin\windows\go-petstore.bat to update the petstore samples (tested by the CI)

@wing328 wing328 modified the milestones: 3.0.0, 3.0.1 Jun 1, 2018
@wing328 wing328 removed this from the 3.0.1 milestone Jun 11, 2018
@wing328
Copy link
Member

wing328 commented Jun 12, 2018

I've resolved the conflicts locally, updated the sample and triggered a CI job to test the updated Go Petstore. The result is good: https://circleci.com/gh/OpenAPITools/openapi-generator/617 (the failure is due to Scala client downloading dependencies, not related to Go client changes).

If no one has any feedback/question, I'll merge it on coming Friday.

cc @antihax @bvwells

@jimschubert
Copy link
Member

@wing328 bumping this. You should be able to do a 3 way merge locally and assign the author info manually, if that's cool with @ilk.

@wing328 wing328 merged commit 4664c07 into OpenAPITools:master Jun 21, 2018
@wing328
Copy link
Member

wing328 commented Jun 21, 2018

@jimschubert thanks. I just merge it and will send another PR to update the Go petstore sample

@wing328 wing328 added this to the 3.0.3 milestone Jun 21, 2018
aserkes pushed a commit to aserkes/openapi-generator that referenced this pull request Sep 21, 2022
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
…-9.x

chore(deps): update dependency ts-node to v9
@bergerdenes
Copy link

bergerdenes commented Nov 24, 2023

This change made Map<String, Object> unmarshaling in Go impossible. :(
At least there should be an option left to use the previous behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go] map type object *interface{} convert problem
4 participants