[cpp-restsdk] Generate mockable APIs #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etherealjoy
requested changes
Jul 19, 2018
| @@ -22,11 +22,24 @@ namespace {{this}} { | |||
|
|
|||
| using namespace {{modelNamespace}}; | |||
|
|
|||
| class {{declspec}} {{classname}} | |||
| class {{declspec}} I{{classname}} | |||
There was a problem hiding this comment.
I think this part should be encapsulated with the new mustache variable, so that current users are not impacted
| { | ||
| public: | ||
| {{classname}}( std::shared_ptr<ApiClient> apiClient ); | ||
| virtual ~{{classname}}(); | ||
| ~{{classname}}() override; |
| @@ -41,7 +54,7 @@ public: | |||
| {{#allParams}} | |||
| {{^required}}boost::optional<{{/required}}{{#isFile}}std::shared_ptr<{{/isFile}}{{{dataType}}}{{#isFile}}>{{/isFile}}{{^required}}>{{/required}} {{paramName}}{{#hasMore}},{{/hasMore}} | |||
| {{/allParams}} | |||
| ); | |||
| ) override; | |||
|
@etherealjoy Addressed all your comments! |
etherealjoy
approved these changes
Jul 23, 2018
|
@Peaches491 thanks for the PR, which has been merged into master @etherealjoy thanks for reviewing the change. |
4 tasks
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Port GMock feature from NativeInstruments swagger-codegen fork: NativeInstruments/swagger-codegen#9 * Update petstore for Mockable APIs * Fix shared_ptr in templates for File params * Add guards in templates for GMock APIs * Regenerate samples without GMocks * Add useful constructors for GMock APIs * Add constructors to API header interface * Update samples with explicit monadic constructors * Add default implementations for destructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
Port of NativeInstruments/swagger-codegen#9 to
openapi-generatorproject.Description of the original PR