Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][RESTEasy] Fix version incompatibility #594

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

delenius
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The RESTEasy client has incompatible versions for its Jackson libraries, as can be seen in this partial output from mvn dependency:tree in a generated client:

[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.6.4:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.6.4:compile
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.6.4:compile
[INFO] +- com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.6.4:compile
[INFO] +- joda-time:joda-time:jar:2.9.9:compile
[INFO] +- com.brsanthu:migbase64:jar:2.2:compile
[INFO] +- org.jboss.resteasy:resteasy-jackson2-provider:jar:3.1.3.Final:compile
[INFO] |  \- com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.8.6:compile
[INFO] |     +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.8.6:compile
[INFO] |     \- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.8.6:compile
[INFO] +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.6.4:compile
[INFO] +- com.github.joschi.jackson:jackson-datatype-threetenbp:jar:2.6.4:compile

The core library (etc) uses 2.6.4, but resteast-jackson2-provider uses 2.8.6.

This causes a NoSuchMethodError when trying to invoke an API call from the client, in some cases. This PR fixes this by bumping the jackson version up to 2.8.6.

Note that previously, the version for the jackson-datatype-threetenbp library was also set to ${jackson-version}. However, this no longer works, because there is no 2.8.6 version of that library, so I kept that at 2.6.4 (which seems to work).

@wing328
Copy link
Member

wing328 commented Jul 19, 2018

The shippable error is not related.

The PR looks good to me

cc Java technical committee:

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 merged commit 995edc0 into OpenAPITools:master Jul 19, 2018
@wing328
Copy link
Member

wing328 commented Jul 19, 2018

@delenius FYI. I've filed #597 to update Gradle and Sbt build file with similar changes.

@jeff9finger
Copy link
Contributor

LGTM 👍

@wing328 wing328 changed the title Fix version incompatibility in resteasy client [Java][RESTEasy] Fix version incompatibility Jul 25, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants