-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript][jQuery] Fix promise resolution #581
[typescript][jQuery] Fix promise resolution #581
Conversation
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. this is a breaking change, but the return value did not correspond to the type, so this should be fine.
@grollinger thanks for your PR. you could also add the |
the shippable build fails because |
The type annotation that is generated for an API states that the JQueryPromise<...> will be resolved with a single value. The implementation, on the other hand resolves with two. This changes the implementation to resolve the promise in accordance with the type annotation. It also adds another type specifying what will be passed if the promise is rejected.
120a1c1
to
3aeebb9
Compare
Thanks for pointing it out. We will take care of that |
@grollinger thanks for the PR, which has been merged into master. @macjohnny thanks for reviewing the PR. |
* typescript-jquery: fix promise resolution The type annotation that is generated for an API states that the JQueryPromise<...> will be resolved with a single value. The implementation, on the other hand resolves with two. This changes the implementation to resolve the promise in accordance with the type annotation. It also adds another type specifying what will be passed if the promise is rejected. * Update petstore sample for typescript-jquery
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Description of the PR
(Port of swagger-api/swagger-codegen#8385)
Resolves #581