Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add --global-property for -D replacement #5687

Merged
merged 1 commit into from
Apr 2, 2020

Commits on Mar 24, 2020

  1. [cli] Add --global-property for -D replacement

    -D option has been deprecated as it was previously used to:
    
    * Pass "system properties"
    * Pass additional properties
    
    This was confusing because we already have --additional-properties and
    because Java System Properties are passed as -D before program
    arguments.
    
    Confusion around the -D option had existed for some time, but when we
    introduced the thread-safe GlobalSettings to avoid overwriting Java
    System Properties, we created a hard break from Java System Properties
    in the generator. This also disconnected the previous "system
    properties" from accepting additional properties.
    
    Once these newly deprecated methods are removed, we will have a clear
    separation of concerns between:
    
    * Java System Properties
    * Global generator properties (used as workflow context)
    * Additional properties (used as generator options)
    
    This commit marks multiple places for cleanup in 5.0. These will be
    breaking changes, and lower effort to break in 5.0 with deprecation
    warnings now rather than adding sibling properties throughout the code
    and potentially introducing logic errors.
    jimschubert committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    5001ac8 View commit details
    Browse the repository at this point in the history