Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slim] Generation of UnitTest stubs #566

Merged
merged 4 commits into from
Jul 16, 2018

Conversation

ybelenko
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

PHPUnit4 documentation

  1. PHPUnit4.8 added to Composer dev dependencies.
  2. PHPUnit config file created and script called test added to Composer.
  3. Model and Api test templates created. It's just stubs for now without any assertions.
  4. All samples has been refreshed.

Test script output below:

$ composer test
Deprecated: The each() function is deprecated. This message will be suppressed on further calls in C:\wamp64\www\openapi-generator\samples\server\petstore\php-slim\vendor\phpunit\phpunit\src\Util\Getopt.php on line 38
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

..................................

Time: 490 ms, Memory: 4.00MB

OK (34 tests, 0 assertions)
> phpunit --testsuite Models

Deprecated: The each() function is deprecated. This message will be suppressed on further calls in C:\wamp64\www\openapi-generator\samples\server\petstore\php-slim\vendor\phpunit\phpunit\src\Util\Getopt.php on line 38
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

...............................................................  63 / 133 ( 47%)
............................................................... 126 / 133 ( 94%)
.......

Time: 229 ms, Memory: 6.00MB

OK (133 tests, 0 assertions)

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@ackintosh ackintosh merged commit 925ae68 into OpenAPITools:master Jul 16, 2018
@ybelenko ybelenko deleted the slim_enhancement_unittest branch July 16, 2018 05:26
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* [Slim] Add PHPUnit4 to Composer

* [Slim] Configure PHPUnit

* [Slim] Add Model and Api test templates

* [Slim] Refresh Slim samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants