Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Fix openapi.json location rename #56

Merged

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented May 16, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Swashbuckle generation was missing the configuration to rename from
default swagger.json to openapi.json (expected by change in SwaggerUI's
configuration for the endpoint).

This generates to the appropriate location and updates the sample to
load the Swagger UI properly on run.

Fixes an issue I found while evaluating #53.

NOTE: {documentName} is not a mustache variable. It is a templated placeholder for Swashbuckle to replace with the version pulled from the generated document.

Swashbuckle generation was missing the configuration to rename from
default swagger.json to openapi.json (expected by change in SwaggerUI's
configuration for the endpoint).

This generates to the appropriate location and updates the sample to
load the Swagger UI properly on run.
@wing328 wing328 added this to the 3.0.0 milestone May 16, 2018
@wing328 wing328 merged commit 9a8183a into OpenAPITools:master May 16, 2018
@jimschubert jimschubert deleted the fix-aspnetcore-document-name branch May 16, 2018 03:27
aserkes added a commit to aserkes/openapi-generator that referenced this pull request Sep 21, 2022
* Updated and new sample config files; not committing the resulting generated sample code yet

* fix samples compilation errors (OpenAPITools#56)

Signed-off-by: aserkes <[email protected]>

Signed-off-by: aserkes <[email protected]>

Signed-off-by: aserkes <[email protected]>
Co-authored-by: aserkes <[email protected]>
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
…ipt-eslint-monorepo

chore(deps): update typescript-eslint monorepo to v2.34.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants