Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Move feature set setter #5460

Merged
merged 1 commit into from
Feb 28, 2020

Commits on Feb 27, 2020

  1. [all] Move feature set setter

    When I originally implemented the feature set code, I added the
    getter/setter on DefaultCodegen and CodegenConfig as well as on
    GeneratorMetadata. GeneratorMetadata also includes the library variation
    features. When I went to add library-specific features, I realized the
    discrepancy.
    
    This removes the public setter from DefaultCodegen/CodegenConfig, and
    adds a protected modifyFeatureSet which accepts a lambda and hides the
    builder logic away in the method.
    
    This will be a breaking change for anyone who's created a custom
    generator in 4.2.3, so the impact is very limited.
    jimschubert committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f12a821 View commit details
    Browse the repository at this point in the history