Update modelGeneric.mustache

[shwetashukla]

If maxlength is specified for a property type enum it there should be .ToString() appended before length check

#5294

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
  @mandrean @jimschubert @frankyjuang @shibayan

[shibayan]

Validating the enum value length looks very strange to me.
In general, you should validate that the value is defined as an enum values.

[shwetashukla]

I had looked at the code generated in other languages and in those enums were checked for values. But in C# if enum is assigned an incorrect value it would either throw an exception or if marked nullable enum it would contain null. Also maxLength as per open api specification is valid tag with enums .

[shibayan]

The value is always checked when converting to an enum, which means that this validation method will already contain the correct enum value.
It seems strange to treat a value successfully converted as an enum as an error with maxlength. Is it a bug of OpenAPI definition?

[shwetashukla]

The value is always checked when converting to an enum, which means that this validation method will already contain the correct enum value.
It seems strange to treat a value successfully converted as an enum as an error with maxlength. Is it a bug of OpenAPI definition?

As per OpenAPI specification enum with maxlength is a valid combination which even i also find a bit strange , but even in that case the code generated should not have compilation errors .
So do you suggest that we skip maxLength and minLength check for enums?
I also opened conversation with OpenAPI-Specification team.

[wing328]

Based on the discussion in OAI/OpenAPI-Specification#2153, there's no need to validate maxLength, minLength for enum.

[wing328]

@shwetashukla thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861