Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Rename files/folders #534

Merged
merged 13 commits into from
Jul 13, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Jul 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related issue: #138
Naming rules: #138 (comment)

language/framework (-g value) generator template dir script sample folder
ruby-on-rails RubyOnRailsServerCodegen rails5 -> ruby-on-rails-server rails5-petstore-server.sh -> ruby-on-rails-server-petstore.sh rails5 -> ruby-on-rails
ruby-sinatra RubySinatraServerCodegen sinatra -> ruby-sinatra-server sinatra-petstore-server.sh -> ruby-sinatra-server-petstore.sh sinatra -> ruby-sinatra
ruby RubyClientCodegen ruby -> ruby-client ruby-petstore.sh -> ruby-client-petstore.sh ruby

@ackintosh
Copy link
Contributor Author

Technical committee: @cliffano @zlx

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wing328 wing328 merged commit 26e70fe into OpenAPITools:master Jul 13, 2018
@wing328 wing328 added this to the 3.1.1 milestone Jul 13, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Rename templateDir: rails5 -> ruby-on-rails-server

* Rename script: rails5-petstore-server.sh -> ruby-on-rails-server-petstore.sh

* Rename sample folder: rails5 -> ruby-on-rails

* Rename script(openapi3): rails5-petstore-server.sh -> ruby-on-rails-server-petstore.sh

* Update ruby-on-rails-server-petstore.sh

* Rename templateDir: sinatra -> ruby-sinatra-server

* Rename script: sinatra-petstore-server.sh -> ruby-sinatra-server-petstore.sh

* Rename sample folder: sinatra -> ruby-sinatra

* Update script

* Rename templateDir: ruby -> ruby-client

* Rename script: ruby-petstore.sh -> ruby-client-petstore.sh

* Update scripts

* Update samples

- bin/ruby-sinatra-server-petstore.sh
- bin/ruby-on-rails-server-petstore.sh
- bin/ruby-client-petstore.sh
- bin/security/ruby-client-petstore.sh
ota42y added a commit to ota42y/openapi-generator that referenced this pull request Mar 4, 2019
`./bin/ruby-petstore.sh` renamed by OpenAPITools#534 so we should fix CONTRIBUTING.md
wing328 pushed a commit that referenced this pull request Mar 7, 2019
* fix test script path in CONTRIBUTING.md

`./bin/ruby-petstore.sh` renamed by #534 so we should fix CONTRIBUTING.md

* fix website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants