[Golang][client] fix formData file parameter name use
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jul 12, 2018
| @@ -573,7 +571,6 @@ paths: | |||
| parameters: | |||
| - name: enum_header_string_array | |||
| in: header | |||
| explode: true | |||
There was a problem hiding this comment.
Seems like there's still an issue with the online converter. I'll open an issue tomorrow.
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…ls#506) * support form-data file MIME `name` parameter * update test spec and Go client for form-data file name * update samples for ensure-up-to-date * update mustache template * update samples for Go client * improve assignment location * update samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.@antihax
@bvwells
Description of the PR
When a parameter in
formDatawith typefileis sent, the parameter name is hardcoded tofilebut it should be set to the parameter name because it needs to be used in the MIMEmultipart/form-dataContent-Dispositionheader. As an example, if an API requires the following and the parameter name is set toattachmentin the spec,APIClient.prepareRequestwill still setnameto be hardcoded tofile.This issue is described in more detail here:
localVarFormFileNamewas select as the variable name to hold this info because it aligns withlocalVarFormParamsand the name is specifically associated with the file, e.g.localVarFileNameandlocalVarFileBytes. It is also more inline with Go'sFormFileinCreateFormFile.This PR solves the immediate issue of not using the parameter name. A future enhancement will be to support an array of files per parameter and multiple file parameters.