[PHP] Refactor php client generator #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ./bin/php-lumen-petstore-server.sh > /dev/null 2>&1 - ./bin/php-ze-ph-petstore-server.sh > /dev/null 2>&1
|
technical committee: @jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09) |
wing328
approved these changes
Jul 17, 2018
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Extends AbstractPhpCodegen instead of DefaultCodegen * Remove fully duplicated methods with AbstractPhpCodegen * Remove duplicated properties with AbstractPhpCodegen * Remove duplicated codes in constructor with AbstractPhpCodegen * Add typeMapping "date". Moved from PhpClientCodegen refs: OpenAPITools@3c34c0b#diff-f1801ef05a7926bf394c90f44ae4ab3dL132 * Remove duplicated codes in processOpts() * Remove unnecessary 'implements' * Remove unnecessary method override * Use setter * Merge getTypeDeclaration() into AbstractPhpCodegen * Merge processOpts() into AbstractPhpCodegen refs: * OpenAPITools@296e6d3#diff-f1801ef05a7926bf394c90f44ae4ab3dL139 * OpenAPITools@296e6d3#diff-f1801ef05a7926bf394c90f44ae4ab3dL147 * OpenAPITools@296e6d3#diff-f1801ef05a7926bf394c90f44ae4ab3dL153 * tweak * Optimize IF statement * Remove duplicated methods * Merge setParameterExampleValue() into AbstractPhpCodegen * Merge toEnumVarName() into AbstractPhpCodegen * Merge toEnumName() into AbstractPhpCodegen * Merge escapeUnsafeCharacters() into AbstractPhpCodegen * Merge postProcessOperationsWithModels() into AbstractPhpCodegen * tweak * Recover missing method refs: OpenAPITools@2ad0f6f#diff-f1801ef05a7926bf394c90f44ae4ab3dL91 * Tweak test case refs: OpenAPITools@4e7b7af * Remove unnecessary 'import' * Update lumen and ze-ph samples - ./bin/php-lumen-petstore-server.sh > /dev/null 2>&1 - ./bin/php-ze-ph-petstore-server.sh > /dev/null 2>&1 * Update slim samples * Fix script name * Update silex samples * Update kotlin-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
This PR improves PhpClientCodegen.
the updates of samples after this refactoring