Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang][client] fix RFC-3339 date-time query param #502

Merged

Conversation

grokify
Copy link
Member

@grokify grokify commented Jul 8, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax
@bvwells

Description of the PR

Resubmitting #325

I just used 3.1.0 to regenerate the go-ringcentral client and noticed that while this was previously merged, the issue persists in the release or master branch.

It was merged into 3.1.x and mentioned on release page, but did not get into the actual file.

@wing328
Copy link
Member

wing328 commented Jul 12, 2018

@grokify thanks again for the PR but after reviewing the git log, I still have no clue how this could have happened. I'll use "git bisect" tomorrow to see if I can figure out what's wrong.

Merging this fix into master for the time being.

@wing328
Copy link
Member

wing328 commented Aug 2, 2018

UPDATE: the original change was rolled back by 478b0d6#diff-2faebed03061f084b33bf45cb4397690.

I'm reviewing other changes in that commit to see what else has been rolled back.

@wing328
Copy link
Member

wing328 commented Aug 2, 2018

Only 2 PRs (merged before Jun 19) were rolled back

Both have been added back to the latest master.

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants