Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Update to --generator-name / -g, Fix #442 #491

Merged

Conversation

grokify
Copy link
Member

@grokify grokify commented Jul 7, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

fix #442

@jmini
Copy link
Member

jmini commented Jul 7, 2018

@grokify can you remove/revert 92f7771 from this PR?

This reverts commit 92f7771.
@grokify
Copy link
Member Author

grokify commented Jul 7, 2018

@jmini Of course. Reverted.

@jmini jmini added this to the 3.1.1 milestone Jul 7, 2018
@jmini jmini merged commit b380e8f into OpenAPITools:master Jul 7, 2018
@grokify grokify deleted the cli/enhance/add-generator-name-option branch July 7, 2018 05:59
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jul 7, 2018
* master:
  [CLI] Add --generator-name / -g to config-help (OpenAPITools#491)
  Update README.md (OpenAPITools#493)
  Update README.md (OpenAPITools#488)
  Prepare version 3.1.1-SNAPSHOT (OpenAPITools#487)
@grokify grokify restored the cli/enhance/add-generator-name-option branch July 8, 2018 22:00
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: config-help still uses -l instead of -g
3 participants