-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin][client] Use OffsetDateTime to represente date-time received by the server #4835
Merged
wing328
merged 10 commits into
OpenAPITools:master
from
4brunu:feature/kotlin-date-time
Dec 20, 2019
Merged
[kotlin][client] Use OffsetDateTime to represente date-time received by the server #4835
wing328
merged 10 commits into
OpenAPITools:master
from
4brunu:feature/kotlin-date-time
Dec 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
@4brunu as discussed, let's consider this a bug fix and if users still want to use |
# Conflicts: # docs/generators/kotlin.md # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinClientCodegen.java # modules/openapi-generator/src/main/resources/kotlin-client/jvm-common/infrastructure/OffsetDateTimeAdapter.kt.mustache # modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-retrofit2/infrastructure/OffsetDateTimeAdapter.kt.mustache # modules/openapi-generator/src/main/resources/kotlin-client/libraries/retrofit2/infrastructure/Serializer.kt.mustache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Kotlin client uses LocalDateTime to represent the date-time received from the server.
This is because because LocalDateTime doesn't have a notion of timezone.
It would be better to represent the date time received by the server in a OffsetDateTime which contains the timezone information.
The Java generator and the KotlinSpringServer also use the OffsetDateTime.
openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Lines 471 to 476 in fb0479a
openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java
Lines 104 to 107 in fb0479a
This PR also fixes #4834
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11)